gengjiayuan/MetaCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(editor): create scene context objects at root

Browse Source
This commit is contained in:
ayuan9957 2026-06-23 17:35:47 +08:00
parent 097e1c9475
commit 453abfbf46
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Source/MetaCoreEditor/Private/MetaCoreEditorApp.cpp
View File

@ -931,7 +931,7 @@ void MetaCoreConfigureChineseFont() {
void MetaCoreDrawSceneViewContextMenu(MetaCoreEditorContext& editorContext, MetaCoreId contextObjectId) {
const MetaCoreGameObject contextObject = editorContext.GetScene().FindGameObject(contextObjectId);
const bool hasContextObject = static_cast<bool>(contextObject);
const std::optional<MetaCoreId> forcedParentId = hasContextObject ? std::optional<MetaCoreId>(contextObjectId) : std::nullopt;
const std::optional<MetaCoreId> forcedParentId = hasContextObject ? std::optional<MetaCoreId>(contextObjectId) : std::optional<MetaCoreId>(0);
if (hasContextObject) {
ImGui::TextDisabled("Object: %s", contextObject.GetName().c_str());

12
tests/MetaCoreSmokeTests.cpp
View File

@ -356,6 +356,18 @@ void MetaCoreTestHierarchyEditingCommandsDirtyAndUndo() {
MetaCoreExpect(scenePersistenceService->SaveCurrentScene(editorContext), "Hierarchy command scene should save after create");
MetaCoreExpect(!scenePersistenceService->IsSceneDirty(), "Hierarchy command scene should be clean after create save");
editorContext.SelectOnly(*createdId);
const auto forcedRootId = sceneEditingService->CreateGameObject(
editorContext,
"ForcedRootObject",
false,
std::optional<MetaCore::MetaCoreId>{0}
);
MetaCoreExpect(forcedRootId.has_value(), "CreateGameObject with forced root parent should create an object");
MetaCoreExpect(scene.FindGameObject(*forcedRootId).GetParentId() == 0, "CreateGameObject forced root parent should ignore active selection");
MetaCoreExpect(scenePersistenceService->SaveCurrentScene(editorContext), "Hierarchy command scene should save after forced root create");
MetaCoreExpect(!scenePersistenceService->IsSceneDirty(), "Hierarchy command scene should be clean after forced root create save");
MetaCoreExpect(sceneEditingService->RenameGameObject(editorContext, *createdId, "HierarchyObjectRenamed"), "RenameGameObject command should rename object");
MetaCoreExpect(scenePersistenceService->IsSceneDirty(), "RenameGameObject command should mark scene dirty");
MetaCoreExpect(editorContext.UndoCommand(), "Undo RenameGameObject should succeed");