Doni/ModelHandle
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Better error reporting.

Browse Source
This commit is contained in:
kovacsv 2022-01-14 18:20:36 +01:00
parent 7dd1b0a201
commit d4d4c1fad4
5 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source/engine/import/importer3ds.js
View File

@ -649,7 +649,7 @@ export class Importer3ds extends ImporterBase
ReadChunks (reader, endByte, onChunk) ReadChunks (reader, endByte, onChunk)
{ {
while (reader.GetPosition () <= endByte - 6) { while (reader.GetPosition () <= endByte - 6) {
let chunkId = reader.ReadUnsignedInteger16 (); let chunkId = reader.ReadUnsignedInteger16 ();
let chunkLength = reader.ReadUnsignedInteger32 (); let chunkLength = reader.ReadUnsignedInteger32 ();
onChunk (chunkId, chunkLength); onChunk (chunkId, chunkLength);
} }

2
source/engine/import/importerbase.js
View File

@ -51,7 +51,7 @@ export class ImporterBase
} }
if (IsModelEmpty (this.model)) { if (IsModelEmpty (this.model)) {
this.error = true; this.SetError ('The model doesn\'t contain any meshes.');
callbacks.onError (); callbacks.onError ();
callbacks.onComplete (); callbacks.onComplete ();
return; return;

4
source/website/eventhandler.js
View File

@ -5,10 +5,10 @@ export function SetEventHandler (eventHandler)
eventHandlerFunc = eventHandler; eventHandlerFunc = eventHandler;
} }
export function HandleEvent (eventName, eventLabel) export function HandleEvent (eventName, eventLabel, eventParams)
{ {
if (eventHandlerFunc === undefined || eventHandlerFunc === null) { if (eventHandlerFunc === undefined || eventHandlerFunc === null) {
return; return;
} }
eventHandlerFunc (eventName, eventLabel); eventHandlerFunc (eventName, eventLabel, eventParams);
} }

4
source/website/website.js
View File

@ -406,7 +406,9 @@ export class Website
} else if (importError.code === ImportErrorCode.FailedToLoadFile) { } else if (importError.code === ImportErrorCode.FailedToLoadFile) {
HandleEvent ('failed_to_load_file', extensionsStr); HandleEvent ('failed_to_load_file', extensionsStr);
} else if (importError.code === ImportErrorCode.ImportFailed) { } else if (importError.code === ImportErrorCode.ImportFailed) {
HandleEvent ('import_failed', extensionsStr); HandleEvent ('import_failed', extensionsStr, {
error_message : importError.message
});
} }
} }
}); });

5
website/index.html
View File

@ -34,10 +34,11 @@
<!-- analytics start --> <!-- analytics start -->
<script type="text/javascript"> <script type="text/javascript">
OV.SetWebsiteEventHandler ((eventName, eventData) => { OV.SetWebsiteEventHandler ((eventName, eventLabel, eventParams) => {
console.log ({ console.log ({
eventName : eventName, eventName : eventName,
eventData : eventData eventData : eventLabel,
eventParams : eventParams
}); });
}); });
</script> </script>