From 7146bc0e2a9b7ebab0ad2cd59692f94487885dde Mon Sep 17 00:00:00 2001 From: kovacsv Date: Mon, 17 Jan 2022 21:01:51 +0100 Subject: [PATCH] Fix some DeepScan analysis errors. --- source/engine/model/material.js | 6 ------ source/engine/viewer/navigation.js | 3 +-- source/engine/viewer/viewer.js | 2 +- 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/source/engine/model/material.js b/source/engine/model/material.js index 331da54..2c48ad5 100644 --- a/source/engine/model/material.js +++ b/source/engine/model/material.js @@ -35,9 +35,6 @@ export class TextureMap IsEqual (rhs) { - if (this.name !== rhs.name) { - return false; - } if (this.name !== rhs.name) { return false; } @@ -259,9 +256,6 @@ export class PhysicalMaterial extends FaceMaterial export function TextureIsEqual (a, b) { - if (a.name !== b.name) { - return false; - } if (a.name !== b.name) { return false; } diff --git a/source/engine/viewer/navigation.js b/source/engine/viewer/navigation.js index 1e3f6ff..a4cc873 100644 --- a/source/engine/viewer/navigation.js +++ b/source/engine/viewer/navigation.js @@ -514,9 +514,8 @@ export class Navigation OnMouseWheel (ev) { - ev.preventDefault (); - let params = ev || window.event; + params.preventDefault (); let delta = -params.deltaY / 40; let ratio = 0.1; diff --git a/source/engine/viewer/viewer.js b/source/engine/viewer/viewer.js index d0da17f..3872da1 100644 --- a/source/engine/viewer/viewer.js +++ b/source/engine/viewer/viewer.js @@ -86,7 +86,7 @@ export class UpVector if (this.direction === Direction.X) { newCamera.up = new Coord3D (1.0, 0.0, 0.0); newCamera.eye = newEye; - } if (this.direction === Direction.Y) { + } else if (this.direction === Direction.Y) { newCamera.up = new Coord3D (0.0, 1.0, 0.0); newCamera.eye = newEye; } else if (this.direction === Direction.Z) {