From 0663de32ad9cfbd82f3ce06eecafcc9d7869f76f Mon Sep 17 00:00:00 2001 From: kovacsv Date: Fri, 24 Oct 2014 17:35:26 +0200 Subject: [PATCH] Make JSHint more strict. --- embeddable/include/online3dembedder.js | 7 +++---- tools/jshintconfig.json | 22 ++++++++++++++-------- 2 files changed, 17 insertions(+), 12 deletions(-) diff --git a/embeddable/include/online3dembedder.js b/embeddable/include/online3dembedder.js index cfd1748..4e2c66f 100644 --- a/embeddable/include/online3dembedder.js +++ b/embeddable/include/online3dembedder.js @@ -1,4 +1,4 @@ -function LoadOnline3DModels () +LoadOnline3DModels = function () { function Error (viewerElement, message) { @@ -15,7 +15,6 @@ function LoadOnline3DModels () return; } - var myThis = this; var urlList = urls.split ('|'); JSM.ConvertURLListToJsonData (urlList, { onError : function () { @@ -37,7 +36,7 @@ function LoadOnline3DModels () var currentMeshIndex = 0; var environment = new JSM.AsyncEnvironment ({ - onStart : function (taskCount/*, meshes*/) { + onStart : function (/*taskCount, meshes*/) { viewer.EnableDraw (false); }, onProcess : function (currentTask, meshes) { @@ -75,4 +74,4 @@ function LoadOnline3DModels () Error (viewer, 'No browser support.'); } } -} +}; diff --git a/tools/jshintconfig.json b/tools/jshintconfig.json index e2194e6..051343c 100644 --- a/tools/jshintconfig.json +++ b/tools/jshintconfig.json @@ -1,12 +1,18 @@ { + "maxerr" : 50, + "curly" : true, + "forin" : true, + "latedef" : true, + "nonew" : true, + "quotmark" : true, + "unused" : true, + "funcscope" : true, + "lastsemic" : true, + "loopfunc" : true, + "shadow" : true, "globals" : { - "JSM" : true, - "ImporterApp" :true, - "ImporterMenu" : true, - "ImporterViewer" : true, - "ImporterButtons" : true, - "ImporterProgressBar" : true, - "InfoTable" : true, - "THREE" : false + "JSM" : false, + "THREE" : false, + "requestAnimationFrame" : false } }