Doni/CreoOtkPluging
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: correct occlusion algorithm logic in shell analysis

Browse Source 
- Change sorting from farthest-first to nearest-first (minProj ascending)
- Fix occlusion boundary initialization from +infinity to -infinity
- Correct visibility logic: near components occlude far components
- Use max() for boundary update to ensure monotonic increase

This fixes the issue where internal components were getting too many votes
by ensuring occlusion detection follows physical reality.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
sladro 2025-09-19 19:00:54 +08:00
parent ad226e63a5
commit 8ea0d9ce09
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
CreoManager.cpp
View File

@ -2820,21 +2820,21 @@ CreoManager::ProjectionAnalysisData CreoManager::PerformMultiDirectionalProjecti
projections.push_back({minProj, maxProj, comp.featureId}); projections.push_back({minProj, maxProj, comp.featureId});
} }
// Sort by maximum projection value (farthest first) // Sort by minimum projection value (nearest first)
std::sort(projections.begin(), projections.end(), std::sort(projections.begin(), projections.end(),
[](const ProjectionData& a, const ProjectionData& b) { [](const ProjectionData& a, const ProjectionData& b) {
return a.maxProj > b.maxProj; return a.minProj < b.minProj;
}); });
// Occlusion detection: only unoccluded components are visible // Occlusion detection: near components occlude far components
double occlusionBoundary = std::numeric_limits<double>::max(); double occlusionBoundary = -std::numeric_limits<double>::max();
for (const auto& proj : projections) { for (const auto& proj : projections) {
// If component's farthest point is in front of occlusion boundary, it's visible // If component's nearest point is beyond occlusion boundary, it's visible
if (proj.maxProj < occlusionBoundary) { if (proj.minProj > occlusionBoundary) {
result.visibilityVotes[proj.featureId]++; result.visibilityVotes[proj.featureId]++;
// Update occlusion boundary to this component's nearest point // Update occlusion boundary to this component's farthest point
occlusionBoundary = proj.minProj; occlusionBoundary = std::max(occlusionBoundary, proj.maxProj);
} }
} }
} }